Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

GetCondition func fix #114

Merged
merged 2 commits into from
Dec 19, 2018
Merged

GetCondition func fix #114

merged 2 commits into from
Dec 19, 2018

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Dec 17, 2018

GetCondition func should match the argument condition type


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 73.268% when pulling bb0d979 on johnugeorge:fixes into a4b9016 on kubeflow:master.

@coveralls
Copy link

coveralls commented Dec 17, 2018

Coverage Status

Coverage decreased (-0.1%) to 73.198% when pulling 56d6738 on johnugeorge:fixes into a4b9016 on kubeflow:master.

@johnugeorge
Copy link
Member Author

/assign @gaocegege

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for your contribution!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants