Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mlmd): Upgrade ML Metadata to 1.14.0. #9856

Merged
merged 7 commits into from
Aug 22, 2023

Conversation

zijianjoy
Copy link
Collaborator

@zijianjoy zijianjoy commented Aug 12, 2023

Description of your changes:

  • Upgrade MLMD to the latest version. Fix Upgrade KFP to newer version of MLMD #9848
  • Upgrade MLMD client on the frontend to match MLMD version.
  • Update hack/update-all-requirements.sh to remove the unnecessary call to upgrade requirement.
  • Update third_party/ml-metadata/update_version.sh to point to new v2 location.
  • Update documentation to describe a list of build tool for compiling proto clients.

Checklist:

@zijianjoy
Copy link
Collaborator Author

/retest

@zijianjoy
Copy link
Collaborator Author

/test kubeflow-pipeline-e2e-test

@zijianjoy
Copy link
Collaborator Author

/retest

@zijianjoy
Copy link
Collaborator Author

/test kubeflow-pipeline-mkp-test

@zijianjoy
Copy link
Collaborator Author

/retest

@zijianjoy
Copy link
Collaborator Author

/test kubeflow-pipeline-mkp-test

@zijianjoy
Copy link
Collaborator Author

/test kubeflow-pipeline-mkp-test

1 similar comment
@zijianjoy
Copy link
Collaborator Author

/test kubeflow-pipeline-mkp-test

@zijianjoy
Copy link
Collaborator Author

/test kubeflow-pipeline-mkp-test

@zijianjoy
Copy link
Collaborator Author

/test kubeflow-pipeline-mkp-test

@zijianjoy
Copy link
Collaborator Author

/retest

@google-oss-prow
Copy link

google-oss-prow bot commented Aug 21, 2023

@zijianjoy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 f93a173 link false /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zijianjoy
Copy link
Collaborator Author

/cc @jlyaoyuli

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Aug 22, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit eaec515 into kubeflow:master Aug 22, 2023
1 check passed
connor-mccarthy pushed a commit to connor-mccarthy/pipelines that referenced this pull request Aug 24, 2023
* chore(mlmd): Upgrade ML Metadata to 1.14.0.

* fix requirements, skip visualization.

* go mod tidy

* mlmd new enum in frontend

* mlmd license

* mlmd license again, using the failure test diff

* again
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
* chore(mlmd): Upgrade ML Metadata to 1.14.0.

* fix requirements, skip visualization.

* go mod tidy

* mlmd new enum in frontend

* mlmd license

* mlmd license again, using the failure test diff

* again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade KFP to newer version of MLMD
2 participants