Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): partition KFP SDK source code into runtime and non-runtime code #9710

Merged

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Jul 6, 2023

Description of your changes:
The first step toward extracting a KFP runtime package with minimal-dependencies.

This PR isolates runtime-required code to the dsl/ subpackage. The dsl/ subpackage has no dependencies on other subpackages of the KFP SDK.

Checklist:

@connor-mccarthy connor-mccarthy requested a review from chensun July 6, 2023 19:49
@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow google-oss-prow bot requested review from james-jwu and zijianjoy July 6, 2023 19:49
@connor-mccarthy connor-mccarthy force-pushed the extract-runtime-package-1 branch 6 times, most recently from dcf8f3f to 9b2121a Compare July 6, 2023 20:14
@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy connor-mccarthy force-pushed the extract-runtime-package-1 branch from 9b2121a to 2846ff4 Compare July 6, 2023 21:02
@connor-mccarthy connor-mccarthy marked this pull request as ready for review July 6, 2023 21:02
@google-oss-prow google-oss-prow bot requested review from IronPan and zijianjoy July 6, 2023 21:03
@google-oss-prow
Copy link

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-execution-tests 2846ff4 link false /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@connor-mccarthy
Copy link
Member Author

/assign @chensun

@connor-mccarthy connor-mccarthy changed the title chore(sdk): move dsl objects into new module chore(sdk): partition KFP SDK source code into runtime and non-runtime code Jul 6, 2023
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Jul 7, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants