fix(sdk): relax executor type checking #9481
Conversation
| accepted_types = (int, float) | ||
| # TODO: relax str-typed return to allow all primitive types? | ||
| else: | ||
| accepted_types = (origin_type) |
There was a problem hiding this comment.
nit: superfluous parentheses, since (origin_type) == origin_type
|
@chensun: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
FIx.
ValueError: Function XXX returned value of type <class 'int'>; want type <class 'float'>Fixes: #9442
Checklist: