-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): add experiment_id parameter to create run methods #9004
Conversation
Hi @droctothorpe. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @connor-mccarthy |
FWIW, the |
As for the backend, a run in v1 API could have a resource reference to a parent experiment. In v2, the In v2, we recently marked Adding a reference to the parent experiment by ID instead of name in v1 makes sense to me. |
c3b0a97
to
5be0a6c
Compare
Addressed the yapf finding. Are the other test failures unrelated? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Co-authored-by: alenawang <[email protected]> Co-authored-by: andreafehrman <[email protected]> Co-authored-by: owmasch <[email protected]> Co-authored-by: ryanrusson <[email protected]>
5be0a6c
to
4c9d4f5
Compare
@droctothorpe: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…w#9004) Co-authored-by: alenawang <[email protected]> Co-authored-by: andreafehrman <[email protected]> Co-authored-by: owmasch <[email protected]> Co-authored-by: ryanrusson <[email protected]>
Description of your changes:
Currently,
create_run_from_pipeline_func
andcreate_run_from_pipeline_package
accept anexperiment_name
parameter and lookup the experiment ID with a backend call viacreate_experiment
.This tiny PR lets users pass the experiment ID directly as an optional alternative, circumventing the extra call, and improving alignment between these methods and
create_recurring_run
.It also decouples the experiment handling logic from the run name handling logic. They were interleaved previously.
Checklist: