Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): deprecate .add_node_selector_constraint in favor of .set_accelerator_type #8980

Merged
merged 2 commits into from
Mar 14, 2023
Merged

feat(sdk): deprecate .add_node_selector_constraint in favor of .set_accelerator_type #8980

merged 2 commits into from
Mar 14, 2023

Conversation

connor-mccarthy
Copy link
Member

Description of your changes:
Deprecates pipeline task .add_node_selector_constraint in favor of .set_accelerator_type,
since accelerators can be set on multiple platforms.

Checklist:

@connor-mccarthy connor-mccarthy requested a review from chensun March 13, 2023 22:37
@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow google-oss-prow bot requested review from IronPan and zijianjoy March 13, 2023 22:37
@connor-mccarthy connor-mccarthy marked this pull request as ready for review March 13, 2023 22:39
@connor-mccarthy connor-mccarthy force-pushed the rename-node-selector-to-accelerator-type branch from 01ddee5 to 1e59cb0 Compare March 13, 2023 22:39
@connor-mccarthy connor-mccarthy force-pushed the rename-node-selector-to-accelerator-type branch from 1e59cb0 to dc9a368 Compare March 13, 2023 22:42
@connor-mccarthy
Copy link
Member Author

/assign @chensun
/assign @gkcalat

@connor-mccarthy connor-mccarthy requested review from gkcalat and removed request for IronPan and zijianjoy March 13, 2023 22:42
@connor-mccarthy connor-mccarthy force-pushed the rename-node-selector-to-accelerator-type branch from dc9a368 to 577d7e4 Compare March 13, 2023 23:36
@connor-mccarthy connor-mccarthy mentioned this pull request Mar 13, 2023
Merged
gkcalat
gkcalat reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@gkcalat gkcalat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @connor-mccarthy!
I propose to update the docstring for KFP users.

@connor-mccarthy connor-mccarthy requested a review from gkcalat March 14, 2023 03:09
@connor-mccarthy connor-mccarthy force-pushed the rename-node-selector-to-accelerator-type branch from fa7e090 to b53bcca Compare March 14, 2023 16:09
@gkcalat
Copy link
Member

gkcalat commented Mar 14, 2023

/lgtm
/approve

Thanks, @connor-mccarthy!

@google-oss-prow google-oss-prow bot added the lgtm label Mar 14, 2023
@connor-mccarthy
Copy link
Member Author

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy, gkcalat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-execution-tests b53bcca link unknown /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@connor-mccarthy connor-mccarthy merged commit e96754c into kubeflow:master Mar 14, 2023
rd-pong pushed a commit to rd-pong/pipelines that referenced this pull request Apr 26, 2023
@connor-mccarthy @rd-pong
feat(sdk): deprecate .add_node_selector_constraint in favor of .set_a…
99b57d8 
…ccelerator_type (kubeflow#8980)

* rename method

* update docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkcalat gkcalat gkcalat approved these changes

@chensun chensun Awaiting requested review from chensun

Assignees

@chensun chensun

@gkcalat gkcalat

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connor-mccarthy @gkcalat @chensun