Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): Fix environment variable set in component yaml lost during compilation. Fixes #8884 #8885

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

chensun
Copy link
Member

@chensun chensun commented Feb 23, 2023

Description of your changes:
Fixes #8884

Checklist:

@connor-mccarthy
Copy link
Member

/lgtm

Thanks, @chensun!

Maybe add a release note for the rare case that a user notices a behavior change and want to trace it. Feel free to merge as-is if you prefer.

@google-oss-prow google-oss-prow bot added the lgtm label Feb 23, 2023
@google-oss-prow google-oss-prow bot removed the lgtm label Feb 23, 2023
@chensun
Copy link
Member Author

chensun commented Feb 23, 2023

/lgtm

Thanks, @chensun!

Maybe add a release note for the rare case that a user notices a behavior change and want to trace it. Feel free to merge as-is if you prefer.

Good call. I should have remembered doing that. Fixed.

@connor-mccarthy
Copy link
Member

connor-mccarthy commented Feb 23, 2023

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Feb 23, 2023
Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

@chensun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-execution-tests e684560 link true /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chensun
Copy link
Member Author

chensun commented Feb 23, 2023

kubeflow-pipelines-sdk-execution-tests failure is unrelated to the change and tracked by #8845 and #8846 (pending release)

@chensun chensun merged commit 8d3e0dd into kubeflow:master Feb 23, 2023
@chensun chensun deleted the sdk-env branch February 23, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk] Environment variable set in container not reflected in IR
2 participants