Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): Add default values to timestamps. Fixes #8845 #8857

Merged
merged 2 commits into from
Feb 16, 2023
Merged

fix(backend): Add default values to timestamps. Fixes #8845 #8857

merged 2 commits into from
Feb 16, 2023

Conversation

gkcalat
Copy link
Member

@gkcalat gkcalat commented Feb 15, 2023

Description of your changes:

  • Added default values (int64:0) to timestamps in the backend DB

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gkcalat
Copy link
Member Author

gkcalat commented Feb 15, 2023

/test all

@gkcalat gkcalat changed the title fix(backend): Add default values to timestamps. Closes #8845 fix(backend): Add default values to timestamps. Fixes #8845 Feb 15, 2023
@gkcalat gkcalat marked this pull request as ready for review February 15, 2023 20:04
@gkcalat
Copy link
Member Author

gkcalat commented Feb 15, 2023

Fixes #8845

@chensun
Copy link
Member

chensun commented Feb 16, 2023

/test kubeflow-pipelines-sdk-execution-tests

@google-oss-prow
Copy link

@gkcalat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-execution-tests 212d0c1 link true /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Feb 16, 2023
chensun
chensun approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Feb 16, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit beeaed0 into kubeflow:master Feb 16, 2023
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Mar 9, 2023
@gkcalat @jlyaoyuli
fix(backend): Add default values to timestamps. Fixes kubeflow#8845 (k…
4fac435 
…ubeflow#8857)

* Add default values to timestamps

* Force not-null create, null-able other timestamps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun approved these changes

@Linchin Linchin Awaiting requested review from Linchin

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@chensun chensun

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkcalat @chensun