-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): Accepts higher PyYAML versions #8665
Conversation
Hi @mai-nakagawa. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for this, @mai-nakagawa. /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mai-nakagawa, you can ignore |
@connor-mccarthy Thanks for reviewing. I ran the command successfully without any updates in
|
@connor-mccarthy Should I update in L24 as you specify or in L10? I'm asking it because kfp |
L10 is correct. Good catch!
Looks like the pip-compile output is unchanged. That's no problem. Thanks for letting me know. |
@connor-mccarthy Updated by 75e9eb2. PTAL 🙏 |
I just clicked |
@mai-nakagawa: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm Thanks, @mai-nakagawa! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: connor-mccarthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Fixes #8666.
Looking at the change list of PyYAML 6.0, I believe those changes have no impact to kfp SDK.
Checklist: