Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Accepts higher PyYAML versions #8665

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

mai-nakagawa
Copy link
Contributor

@mai-nakagawa mai-nakagawa commented Jan 11, 2023

Description of your changes:

Fixes #8666.

Looking at the change list of PyYAML 6.0, I believe those changes have no impact to kfp SDK.

Checklist:

@google-oss-prow
Copy link

Hi @mai-nakagawa. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mai-nakagawa mai-nakagawa marked this pull request as ready for review January 11, 2023 08:30
@connor-mccarthy
Copy link
Member

Thanks for this, @mai-nakagawa.

/ok-to-test

Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please run pip-compile against this file per instructions here?

Can you also please update the release notes here?

@connor-mccarthy
Copy link
Member

@mai-nakagawa, you can ignore kubeflow-pipelines-sdk-execution-tests test failures

@mai-nakagawa
Copy link
Contributor Author

Can you please run pip-compile against this file per instructions here?

@connor-mccarthy Thanks for reviewing. I ran the command successfully without any updates in requirements.txt file, getting the following output:

➜  python git:(patch-1) pip-compile --no-emit-index-url requirements.in
WARNING: the legacy dependency resolver is deprecated and will be removed in future versions of pip-tools. The default resolver will be changed to 'backtracking' in pip-tools 7.0.0. Specify --resolver=backtracking to silence this warning.
#
# This file is autogenerated by pip-compile with Python 3.7
# by the following command:
#
#    pip-compile --no-emit-index-url requirements.in
#
absl-py==1.2.0
    # via -r requirements.in
attrs==22.1.0
    # via jsonschema
cachetools==5.2.0
    # via google-auth
certifi==2022.6.15
    # via
    #   kfp-server-api
    #   kubernetes
    #   requests
charset-normalizer==2.1.1
    # via requests
click==8.1.3
    # via
    #   -r requirements.in
    #   typer
cloudpickle==2.1.0
    # via -r requirements.in
deprecated==1.2.13
    # via -r requirements.in
docstring-parser==0.14.1
    # via -r requirements.in
fire==0.4.0
    # via -r requirements.in
google-api-core==2.8.2
    # via
    #   -r requirements.in
    #   google-cloud-core
    #   google-cloud-storage
google-auth==2.11.0
    # via
    #   -r requirements.in
    #   google-api-core
    #   google-cloud-core
    #   google-cloud-storage
    #   kubernetes
google-cloud-core==2.3.2
    # via google-cloud-storage
google-cloud-storage==2.5.0
    # via -r requirements.in
google-crc32c==1.5.0
    # via google-resumable-media
google-resumable-media==2.3.3
    # via google-cloud-storage
googleapis-common-protos==1.56.4
    # via google-api-core
idna==3.3
    # via requests
importlib-metadata==4.12.0
    # via
    #   click
    #   jsonschema
jsonschema==3.2.0
    # via -r requirements.in
kfp-pipeline-spec==0.1.17
    # via -r requirements.in
kfp-server-api==2.0.0a4
    # via -r requirements.in
kubernetes==23.6.0
    # via -r requirements.in
oauthlib==3.2.0
    # via requests-oauthlib
protobuf==3.20.1
    # via
    #   -r requirements.in
    #   google-api-core
    #   googleapis-common-protos
    #   kfp-pipeline-spec
pyasn1==0.4.8
    # via
    #   pyasn1-modules
    #   rsa
pyasn1-modules==0.2.8
    # via google-auth
pyrsistent==0.18.1
    # via jsonschema
python-dateutil==2.8.2
    # via
    #   kfp-server-api
    #   kubernetes
pyyaml==5.4.1
    # via
    #   -r requirements.in
    #   kubernetes
requests==2.28.1
    # via
    #   google-api-core
    #   google-cloud-storage
    #   kubernetes
    #   requests-oauthlib
    #   requests-toolbelt
requests-oauthlib==1.3.1
    # via kubernetes
requests-toolbelt==0.9.1
    # via -r requirements.in
rsa==4.9
    # via google-auth
six==1.16.0
    # via
    #   fire
    #   google-auth
    #   jsonschema
    #   kfp-server-api
    #   kubernetes
    #   python-dateutil
strip-hints==0.1.10
    # via -r requirements.in
tabulate==0.8.10
    # via -r requirements.in
termcolor==1.1.0
    # via fire
typer==0.6.1
    # via -r requirements.in
typing-extensions==4.3.0 ; python_version < "3.9"
    # via
    #   -r requirements.in
    #   importlib-metadata
uritemplate==3.0.1
    # via -r requirements.in
urllib3==1.26.12
    # via
    #   kfp-server-api
    #   kubernetes
    #   requests
websocket-client==1.4.0
    # via kubernetes
wheel==0.37.1
    # via strip-hints
wrapt==1.14.1
    # via deprecated
zipp==3.8.1
    # via importlib-metadata

# The following packages are considered to be unsafe in a requirements file:
# setuptools

@mai-nakagawa
Copy link
Contributor Author

Can you also please update the release notes here?

@connor-mccarthy Should I update in L24 as you specify or in L10? I'm asking it because kfp v2.0.0b10 was already released in last December as per the release history.

@connor-mccarthy
Copy link
Member

@mai-nakagawa

Should I update in L24 as you specify or in L10?

L10 is correct. Good catch!

without any updates in requirements.txt file

Looks like the pip-compile output is unchanged. That's no problem. Thanks for letting me know.

@mai-nakagawa
Copy link
Contributor Author

Should I update in L24 as you specify or in L10?

L10 is correct. Good catch!

@connor-mccarthy Updated by 75e9eb2. PTAL 🙏

@mai-nakagawa mai-nakagawa requested review from connor-mccarthy and removed request for zijianjoy January 14, 2023 04:25
@mai-nakagawa
Copy link
Contributor Author

I just clicked re-request review from @connor-mccarthy, which automatically removed @zijianjoy unexpectedly 😢

@google-oss-prow
Copy link

@mai-nakagawa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-execution-tests 75e9eb2 link true /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@connor-mccarthy
Copy link
Member

/lgtm
/approve

Thanks, @mai-nakagawa!
Manually merging, as kubeflow-pipelines-sdk-execution-tests failures are unrelated to these changes.

@google-oss-prow google-oss-prow bot added the lgtm label Jan 17, 2023
@connor-mccarthy connor-mccarthy merged commit 6040334 into kubeflow:master Jan 17, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mai-nakagawa mai-nakagawa deleted the patch-1 branch January 18, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk] Accept higher PyYAML versions
2 participants