Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): support optional artifact inputs #8623

Merged
merged 7 commits into from
Dec 28, 2022
Merged

feat(sdk): support optional artifact inputs #8623

merged 7 commits into from
Dec 28, 2022

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Dec 21, 2022 •
edited
Loading

Description of your changes:
Supports optional artifact inputs, toward feature parity with KFP SDK v1.

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy
Copy link
Member Author

/assign @chensun
/unhold

@connor-mccarthy connor-mccarthy marked this pull request as ready for review December 22, 2022 15:09
@connor-mccarthy
Copy link
Member Author

/hold on approval of design

chensun
chensun reviewed Dec 28, 2022
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 28, 2022
@connor-mccarthy
Copy link
Member Author

/retest

@google-oss-prow
Copy link

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-execution-tests 720589c link true /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@connor-mccarthy
Copy link
Member Author

/unhold
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy
Copy link
Member Author

kubeflow-pipelines-sdk-execution-tests failures are due to the BE's PipelineSpec validation on the current deployment on which we test. This is fixed in BE HEAD with #8614 and #8614.

Manually merging to temporarily bypass this.

@connor-mccarthy connor-mccarthy merged commit 151e8a3 into kubeflow:master Dec 28, 2022
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Jan 5, 2023
@connor-mccarthy @jlyaoyuli
feat(sdk): support optional artifact inputs (kubeflow#8623)
c43c005 
* add compiler tests

* support optional artifact inputs

* update executor test

* update existing golden snapshot

* add new compiler test/snapshot

* add release note

* bump kfp-pipeline-spec dependency
@connor-mccarthy connor-mccarthy mentioned this pull request Jan 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun left review comments

@IronPan IronPan Awaiting requested review from IronPan

@james-jwu james-jwu Awaiting requested review from james-jwu

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@chensun chensun

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connor-mccarthy @chensun