Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): update golden snapshots with pipeline interface comments #8575

Conversation

connor-mccarthy
Copy link
Member

Description of your changes:
Updates golden snapshots to reflect #8467 so that the associate diff doesn't creep in to unrelated
golden snapshot updates.

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy connor-mccarthy marked this pull request as ready for review December 14, 2022 21:19
@connor-mccarthy
Copy link
Member Author

/assign @chensun

@connor-mccarthy
Copy link
Member Author

/assign @JOCSTAA

@connor-mccarthy
Copy link
Member Author

/unassign @chensun

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 47eb1ca into kubeflow:master Dec 15, 2022
connor-mccarthy added a commit to connor-mccarthy/pipelines that referenced this pull request Dec 15, 2022
@JOCSTAA
Copy link
Contributor

JOCSTAA commented Dec 15, 2022

/lgtm

Linchin pushed a commit that referenced this pull request Dec 21, 2022
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants