Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Add comments to IR YAML file #8467

Merged
merged 20 commits into from
Dec 5, 2022
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,4 @@ repos:
name: docformatter
language: python
entry: docformatter -i -r
exclude: sdk/python/kfp/compiler/compiler_test.py
1 change: 1 addition & 0 deletions sdk/RELEASE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Current Version (in development)

## Features
* Add comments to IR YAML file [\#8467](https://github.com/kubeflow/pipelines/pull/8467)

## Breaking changes

Expand Down
7 changes: 4 additions & 3 deletions sdk/python/kfp/compiler/compiler.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@

from kfp.compiler import pipeline_spec_builder as builder
from kfp.components import base_component
from kfp.components import graph_component
from kfp.components import yaml_component
from kfp.components.types import type_utils


Expand Down Expand Up @@ -79,5 +77,8 @@ def compile(
pipeline_name=pipeline_name,
pipeline_parameters=pipeline_parameters,
)

builder.write_pipeline_spec_to_file(
pipeline_spec=pipeline_spec, package_path=package_path)
pipeline_spec=pipeline_spec,
pipeline_description=pipeline_func.description,
package_path=package_path)
Loading