Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): fix multiple workers writing with gcsfuse bug [KFP SDK v2] #8455

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Nov 15, 2022

Description of your changes:
Fixes a bug where an exception is thrown (non-deterministically) if multiple workers attempt to write to the same file using gcsfuse as the driver. This may or may not be a gcsfuse bug, but either way let's work around it for now in the KFP SDK.

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy connor-mccarthy changed the title fix(sdk): fix multiple workers writing with gcsfuse bug [KFP SDK v1] fix(sdk): fix multiple workers writing with gcsfuse bug [KFP SDK v2] Nov 15, 2022
@connor-mccarthy connor-mccarthy marked this pull request as ready for review November 15, 2022 19:34
@connor-mccarthy
Copy link
Member Author

/assign @chensun

@connor-mccarthy
Copy link
Member Author

/retest

2 similar comments
@connor-mccarthy
Copy link
Member Author

/retest

@connor-mccarthy
Copy link
Member Author

/retest

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 23, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4bb57e6 into kubeflow:master Nov 23, 2022
gkcalat pushed a commit to gkcalat/pipelines that referenced this pull request Nov 23, 2022
…ubeflow#8455)

* fix(sdk): fix multiple workers writing with gcsfuse bug [KFP SDK v1]

* add comment for context
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Jan 5, 2023
…ubeflow#8455)

* fix(sdk): fix multiple workers writing with gcsfuse bug [KFP SDK v1]

* add comment for context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants