fix(sdk): fix boolean default value serialization bug #8444
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
|
/assign @chensun |
| @@ -132,19 +132,19 @@ components: | |||
| defaultValue: gbtree | |||
| parameterType: STRING | |||
| label_column: | |||
| defaultValue: '0' | |||
| defaultValue: 0.0 | |||
There was a problem hiding this comment.
Note that these changes were not the intent of this fix, but the improved default_value setting logic caught this type inconsistency that was previously bypassed.
|
@connor-mccarthy: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Test failures are unrelated to these changes |
|
/lgtm |
|
Manually merging, as test failures are unrelated to this PR. I tested execution of sample pipelines with the corrected |
* add test cases * fix bug * add v1 component yaml back compat changes * update golden snapshot
|
Fixes #8302 |
Description of your changes:
Fixes a bug where default values for boolean inputs were sometimes
serialized as numbers (e.g.,
1.0fortrue) instead of booleans.Checklist:
convention. Learn more about the pull request title convention used in this repository.