Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): add --build-image option to 'kfp components build' to allow users to skip docker build. Fixes #8382 for 2.0 #8387

Merged
merged 2 commits into from
Oct 26, 2022
Merged

feat(sdk): add --build-image option to 'kfp components build' to allow users to skip docker build. Fixes #8382 for 2.0 #8387

merged 2 commits into from
Oct 26, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 25, 2022

Description of your changes:

Adds a CLI flag to allow the user to skip docker build step in kfp component build

Addresses #8382 for SDK version 2.0

Checklist:

@google-oss-prow
Copy link

Hi @browningjp-datatonic. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chensun
Copy link
Member

chensun commented Oct 26, 2022

/ok-to-test

@ghost
Copy link
Author

ghost commented Oct 26, 2022

/retest

@connor-mccarthy connor-mccarthy mentioned this pull request Oct 26, 2022
Closed
connor-mccarthy
connor-mccarthy approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @browningjp-datatonic. This looks great.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Oct 26, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5b75d75 into kubeflow:master Oct 26, 2022
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Jan 5, 2023
@jlyaoyuli
feat(sdk): add --build-image option to 'kfp components build' to allo…
3668c3f 
…w users to skip docker build. Fixes kubeflow#8382 for 2.0 (kubeflow#8387)

* feat: added --build-image/--no-build-image flags to skip docker build

* fix: logic error for warnings/errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@connor-mccarthy connor-mccarthy

Labels
approved lgtm ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chensun @connor-mccarthy