Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): improve KFP SDK reference documentation #8337

Merged

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Oct 6, 2022

Description of your changes:
I intended to add symbol-level permalinks to the documentation and
happened upon several other opportunities for improvements. In total, this
PR:

  • adds symbol-level permalinks
  • adds summary tables to the top of each reference doc page
  • includes right hand side TOC for discoverability in the reference pages,
    similar to how this is done in the "On this page" part of tensorflow
    reference docs
  • exposes Input[] and Output[] type generics to autodoc automatically,
    rather than previously explicit inclusion, allowing for inclusion in summaries
  • exposes all submodules in the left hand side TOC for discoverability
    (previously collapsed under top-level content items)
  • improves symbol grouping/sorting on API reference docs pages
  • alphabetizes the submodule documentation pages

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy connor-mccarthy marked this pull request as ready for review October 6, 2022 19:27
@connor-mccarthy connor-mccarthy force-pushed the sdk-ref-docs-improvements branch from 8f9a231 to 2799632 Compare October 6, 2022 19:53
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 30669e4 into kubeflow:master Oct 17, 2022
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Jan 5, 2023
* use autodoc default options

* sort symbol order by typical usage patterns

* include summary of submodule symbols

* expose Input[] and Output[] type generics

* include tables of contents on API reference docs pages

* expand global TOC for discoverability

* fix missing reference / circular import problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants