fix(sdk): fix NamedTuple output with Dict/List bug #8316
Conversation
|
Skipping CI for Draft Pull Request. |
connor-mccarthy
changed the title
connor-mccarthy
force-pushed
the
fix-namedtuple-output-bug
branch
from
fa60711 to
7b4393d
Compare
|
/retest |
| return {text: text} | ||
|
|
||
| # TODO: ideally should be the canonical type string, rather than the specific annotation as string, but both work | ||
| self.assertEqual(comp.component_spec.outputs['Output'].type, |
There was a problem hiding this comment.
NIT: Should it be comp.component_spec.output instead of comp.component_spec.outputs['Output']?
There was a problem hiding this comment.
In this case it should not be.
This is different than the data passing syntax used within a pipeline definition. This is checking the in-memory representation of the component, wherein all outputs (OutputSpecs) are included in the dictionary .outputs, irrespective of how many outputs there are.
There was a problem hiding this comment.
Got it, thank you for the explanation!
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zijianjoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Fixes a bug where a component with a
NamedTupleoutput with aDictdata type would fail to compile.
Checklist:
convention. Learn more about the pull request title convention used in this repository.