Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): add registry json to package data #7987

Conversation

connor-mccarthy
Copy link
Member

Description of your changes:
Fixes a bug where json files are not distributed with the KFP package.

Checklist:

@connor-mccarthy connor-mccarthy requested a review from chensun July 6, 2022 16:43
@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy connor-mccarthy marked this pull request as ready for review July 6, 2022 16:43
@hilcj
Copy link
Contributor

hilcj commented Jul 6, 2022

/approve
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 6, 2022
@hilcj hilcj assigned connor-mccarthy and unassigned hilcj Jul 6, 2022
@google-oss-prow
Copy link

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 4bc70af link true /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chongyouquan
Copy link
Contributor

/lgtm
/approve

@chensun
Copy link
Member

chensun commented Jul 7, 2022

/lgtm
/approve

Thanks!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, chongyouquan, hilcj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy
Copy link
Member Author

Sample tests are unaffected by this change. Failures are due to other known issues. Manually merging.

@connor-mccarthy connor-mccarthy merged commit 7253203 into kubeflow:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants