Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk/client): implements overriding caching options at submission #7912

Conversation

zichuan-scott-xu
Copy link
Contributor

@zichuan-scott-xu zichuan-scott-xu commented Jun 17, 2022

Description of your changes:

Checklist:

@google-oss-prow
Copy link

Hi @zichuan-scott-xu. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zichuan-scott-xu
Copy link
Contributor Author

/cc @connor-mccarthy

@connor-mccarthy
Copy link
Member

/ok-to-test

@zichuan-scott-xu
Copy link
Contributor Author

/test all

Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Scott! This looks great. And thanks for fixing up the errored type annotations.

In addition to the code-level comments, can you format with yapf?

sdk/python/kfp/client/client_test.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client_test.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client_test.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client.py Outdated Show resolved Hide resolved
Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Scott! This looks great. Just a few very small additional suggestions.

sdk/python/kfp/deprecated/cli/cli.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client_test.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client_test.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client_test.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client.py Show resolved Hide resolved
sdk/python/kfp/client/client.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@zichuan-scott-xu zichuan-scott-xu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! I will make the proposed modification and resubmit the PR.

sdk/python/kfp/client/client_test.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client_test.py Outdated Show resolved Hide resolved
@connor-mccarthy
Copy link
Member

/lgtm
/approve

Thanks, Scott!

@connor-mccarthy
Copy link
Member

/approve
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 1, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy
Copy link
Member

/retest

3 similar comments
@connor-mccarthy
Copy link
Member

/retest

@connor-mccarthy
Copy link
Member

/retest

@connor-mccarthy
Copy link
Member

/retest

sdk/python/kfp/client/client.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client_test.py Outdated Show resolved Hide resolved
@connor-mccarthy
Copy link
Member

@zichuan-scott-xu this LGTM, just need to resolve merge conflicts then we can merge!

@zichuan-scott-xu zichuan-scott-xu force-pushed the override-caching-option-at-submission branch from b7a4103 to 2b30622 Compare July 11, 2022 18:01
@zichuan-scott-xu zichuan-scott-xu requested a review from chensun July 11, 2022 18:33
@connor-mccarthy
Copy link
Member

connor-mccarthy commented Jul 12, 2022

/lgtm
@chensun, PTAL when you have the opportunity

Edited: this was already approved, so the LGTM merged it. Also appears that all of Chen's feedback was addressed.

@google-oss-prow google-oss-prow bot added the lgtm label Jul 12, 2022
@google-oss-prow google-oss-prow bot merged commit b95c5ab into kubeflow:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants