-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk/client): implements overriding caching options at submission #7912
feat(sdk/client): implements overriding caching options at submission #7912
Conversation
Hi @zichuan-scott-xu. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @connor-mccarthy |
/ok-to-test |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Scott! This looks great. And thanks for fixing up the errored type annotations.
In addition to the code-level comments, can you format with yapf
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Scott! This looks great. Just a few very small additional suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! I will make the proposed modification and resubmit the PR.
/lgtm Thanks, Scott! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: connor-mccarthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
3 similar comments
/retest |
/retest |
/retest |
@zichuan-scott-xu this LGTM, just need to resolve merge conflicts then we can merge! |
b7a4103
to
2b30622
Compare
/lgtm Edited: this was already approved, so the LGTM merged it. Also appears that all of Chen's feedback was addressed. |
Description of your changes:
Checklist: