feat(sdk): add retry policy support to kfp v2 #7867
Conversation
|
Skipping CI for Draft Pull Request. |
connor-mccarthy
force-pushed
the
support-task-level-retry-v2
branch
2 times, most recently
from
6b4b62e to
e28dd1a
Compare
|
/test all |
connor-mccarthy
force-pushed
the
support-task-level-retry-v2
branch
from
e28dd1a to
64b026d
Compare
connor-mccarthy
force-pushed
the
support-task-level-retry-v2
branch
from
c0b1aa3 to
6f39253
Compare
| num_retries: int, | ||
| backoff_duration: Optional[str] = None, | ||
| backoff_factor: Optional[float] = None, | ||
| backoff_max_duration: Optional[str] = None) -> 'PipelineTask': |
There was a problem hiding this comment.
Note: A policy parameter was included in the v1 ContainerOp.set_retry method. policy is specific to the Argo workflow spec and not included in the IR RetryPolicy message.
Should we add here, but raise a DeprecationWarning indicating that policy is a no-op? Or omit this parameter in v2 as a small breaking change?
cc: @chensun
connor-mccarthy
force-pushed
the
support-task-level-retry-v2
branch
from
6f39253 to
e4dc3d2
Compare
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
connor-mccarthy
force-pushed
the
support-task-level-retry-v2
branch
from
e4dc3d2 to
c583250
Compare
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
connor-mccarthy
force-pushed
the
support-task-level-retry-v2
branch
from
c583250 to
4105908
Compare
sdk/RELEASE.md
Outdated
| @@ -4,7 +4,8 @@ | |||
|
|
|||
| ## Breaking Changes | |||
|
|
|||
| ### For Pipeline Authors | |||
| ### For Pipeline Authors] | |||
|
|
||
| hello_world(text=text).set_retry( | ||
| num_retries=3, | ||
| backoff_duration='30s', |
There was a problem hiding this comment.
As discussed, remove the parameters that don't work on Vertex.
There was a problem hiding this comment.
on a second look, it's fine to keep this as-is, as long as the samples under test_data/pipelines doesn't show these no-op usage.
|
/retest |
|
/retest |
|
/test all |
connor-mccarthy
force-pushed
the
support-task-level-retry-v2
branch
from
583677a to
bd76c4d
Compare
|
/retest |
|
/lgtm |
|
@connor-mccarthy: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@chensun, can you re-LGTM after rebase and one-character cleanup commit? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Description of your changes:
Adds retry policy support to KFP v2 SDK.
Checklist:
convention. Learn more about the pull request title convention used in this repository.