feat(sdk): improve cli help text #7618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
/test all |
|
/test all |
1 similar comment
|
/test all |
connor-mccarthy
force-pushed
the
improve-help-messages
branch
from
1388e9b to
6df6274
Compare
|
/test all |
|
/hold Merge after #7606 |
|
/unhold |
connor-mccarthy
force-pushed
the
improve-help-messages
branch
from
5897046 to
6d12cd0
Compare
|
/retest |
connor-mccarthy
force-pushed
the
improve-help-messages
branch
from
5fe1a5e to
b191bcd
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
jagadeeshi2i
pushed a commit
to jagadeeshi2i/pipelines
that referenced
this pull request
May 11, 2022
* add docstring parsing utils * implement docstring parsing for help text * implement smoke test of all cli commands * clean up use of optional in docstring * make command descriptions more consistent * fix disable_type_check * update release notes
abaland
pushed a commit
to abaland/pipelines
that referenced
this pull request
May 29, 2022
* add docstring parsing utils * implement docstring parsing for help text * implement smoke test of all cli commands * clean up use of optional in docstring * make command descriptions more consistent * fix disable_type_check * update release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Makes several improvements to the KFP CLI help text, including:
This PR also adds basic smoke tests for each command group of the CLI to ensure they
run and retrieve help text correctly.
Checklist:
more about the pull request title convention used in this repository.