feat(conformance): Enable experiment API tests in KF mode. #7596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 3 flags: - isDebugMode is enables HTTP request/response logging - IsKubeflowMode enables the tests in full Kubeflow mode - resourceNamespace: the namespace/profile under which the test resources are created Added a new HTTP client that uses SA token volume projection auth. The test pods will be set up to project SA token. Plumbed everything through for experiment API tests. The other tests will be enabled in subsequent PRs.
chensun
reviewed
Apr 27, 2022
|
/lgtm Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
jagadeeshi2i
pushed a commit
to jagadeeshi2i/pipelines
that referenced
this pull request
May 11, 2022
…7596) * Conformance: Enable experiment API tests in KF mode. Added 3 flags: - isDebugMode is enables HTTP request/response logging - IsKubeflowMode enables the tests in full Kubeflow mode - resourceNamespace: the namespace/profile under which the test resources are created Added a new HTTP client that uses SA token volume projection auth. The test pods will be set up to project SA token. Plumbed everything through for experiment API tests. The other tests will be enabled in subsequent PRs. * Updated change to address comments.
abaland
pushed a commit
to abaland/pipelines
that referenced
this pull request
May 29, 2022
…7596) * Conformance: Enable experiment API tests in KF mode. Added 3 flags: - isDebugMode is enables HTTP request/response logging - IsKubeflowMode enables the tests in full Kubeflow mode - resourceNamespace: the namespace/profile under which the test resources are created Added a new HTTP client that uses SA token volume projection auth. The test pods will be set up to project SA token. Plumbed everything through for experiment API tests. The other tests will be enabled in subsequent PRs. * Updated change to address comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 flags:
resources are created
Added a new HTTP client that uses SA token volume projection auth. The
test pods will be set up to project SA token.
Plumbed everything through for experiment API tests. The other tests
will be enabled in subsequent PRs.