-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): add .list_pipeline_versions and .unarchive_experiment methods to Client #7563
feat(sdk): add .list_pipeline_versions and .unarchive_experiment methods to Client #7563
Conversation
Skipping CI for Draft Pull Request. |
/test all |
d504f34
to
55cf4cd
Compare
/test all |
|
||
Raises: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still have raises part for those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not get this to raise an exception, so I removed from the docstring. Test case:
from kfp.client import Client
client = Client()
# does not raise an exception
assert client.archive_experiment(experiment_id="dummy_id") is None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thank you!!
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ji-yaqi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
…ods to Client (kubeflow#7563) * add client methods * update release notes
Description of your changes:
Test code for reviewer, if desired:
Checklist:
follow our title convention. Learn more about the pull request title convention used in this repository.