Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): use click for dsl-compile command #7560

Merged

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Apr 13, 2022

Description of your changes:
Uses click for dsl-compile command, instead of argparse. A
future PR will migrate dsl-compile to the main kfp namespace.

Notes for reviewer:

  • Tests continue to pass
  • The CLI signature is the same, though the help messages vary
    slightly:

Before:

usage: dsl-compile [-h] --py PY [--function FUNCTION]
                   [--pipeline-parameters PIPELINE_PARAMETERS]
                   [--namespace NAMESPACE] --output OUTPUT
                   [--disable-type-check]

optional arguments:
  -h, --help            show this help message and exit
  --py PY               local absolute path to a py file.
  --function FUNCTION   The name of the function to compile if 
there are
                        multiple.
  --pipeline-parameters PIPELINE_PARAMETERS
                        The pipeline parameters in JSON dict 
format.
  --namespace NAMESPACE
                        The namespace for the pipeline function
  --output OUTPUT       local path to the output PipelineJob 
json file.
  --disable-type-check  disable the type check, default is 
enabled.

After:

Usage: dsl-compile [OPTIONS]

  Compiles a pipeline written in a .py file.

Options:
  --py TEXT                   Local absolute path to a py file.
                              [required]
  --output TEXT               Local path to the output 
PipelineJob 
JSON
                              file.  [required]
  --function TEXT             The name of the function to 
compile if 
there
                              are multiple.
  --pipeline-parameters TEXT  The pipeline parameters in JSON 
dict 
format.
  --disable-type-check        Disable the type check. Default: 
type 
check
                              is not disabled.
  --help                      Show this message and exit.

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy
Copy link
Member Author

/test all

@google-oss-prow google-oss-prow bot requested a review from zijianjoy April 13, 2022 21:41
@connor-mccarthy
Copy link
Member Author

/hold -- Merge after #7558.

@connor-mccarthy
Copy link
Member Author

/retest

@connor-mccarthy connor-mccarthy marked this pull request as ready for review April 14, 2022 18:38
@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy
Copy link
Member Author

/retest

1 similar comment
@connor-mccarthy
Copy link
Member Author

/retest

@connor-mccarthy connor-mccarthy force-pushed the remove-argparse-from-cli branch from 3499767 to e69b2d1 Compare April 20, 2022 17:01
@connor-mccarthy connor-mccarthy force-pushed the remove-argparse-from-cli branch from e69b2d1 to 69413f8 Compare April 20, 2022 17:09
@google-oss-prow
Copy link

google-oss-prow bot commented Apr 20, 2022

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 69413f8 link true /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chensun
Copy link
Member

chensun commented Apr 20, 2022

/lgtm
/approve

Thanks!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy connor-mccarthy merged commit a554844 into kubeflow:master Apr 20, 2022
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants