feat(sdk): Add pipeline_task_name to PipelineTaskFinalStatus #7464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chensun
commented
Mar 24, 2022
| @@ -16,7 +16,7 @@ google-cloud-storage>=1.20.0,<2 | |||
| # NOTE: Maintainers, please do not require google-auth>=2.x.x | |||
| # Until this issue is closed | |||
| # https://github.com/googleapis/google-cloud-python/issues/10566 | |||
| kfp-pipeline-spec>=0.1.13,<0.2.0 | |||
| kfp-pipeline-spec>=0.1.14,<0.2.0 | |||
There was a problem hiding this comment.
This change itself doesn't have a hard dependency on the new version, but it's related.
|
/lgtm |
connor-mccarthy
approved these changes
Mar 25, 2022
| @@ -15,7 +17,8 @@ | |||
| * Fix wrong kfp import causes wrong sdk_version being set in pipeline_spec. [\#7433](https://github.com/kubeflow/pipelines/pull/7433) | |||
| * Use YAML as default serialization format for package IR [\#7431](https://github.com/kubeflow/pipelines/pull/7431) | |||
| * Support submitting pipeline IR in yaml format via `kfp.client`. [\#7458](https://github.com/kubeflow/pipelines/pull/7458) | |||
| * Enable pip installation from custom PyPI repository [\#7453](https://github.com/kubeflow/pipelines/pull/7453) | |||
There was a problem hiding this comment.
Thanks for moving this 👍🏻
|
/hold |
|
@chensun, looks good! Approve when you'd like to merge. /remove-approve |
|
/remove-approve |
|
/lgtm Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ji-yaqi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abaland
pushed a commit
to abaland/pipelines
that referenced
this pull request
May 29, 2022
…w#7464) * Add pipeline_task_name to PipelineTaskFinalStatus * release note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Checklist: