chore(sdk): make kfp v2 hermetic #7428
Conversation
|
Skipping CI for Draft Pull Request. |
connor-mccarthy
changed the title
| generic_type = typ.__origin__ or getattr( | ||
| typ, '__extra__', None | ||
| ) #In python <3.7 typing.List.__origin__ == None; Python 3.7 has working __origin__, but no __extra__ TODO: Remove the __extra__ once we move to Python 3.7 | ||
| if generic_type in [ |
There was a problem hiding this comment.
nit: We have dropped Python 3.6 support. So we should be able to clean this up.
Feel free to do it here or in a follow-up PR.
There was a problem hiding this comment.
I agree.
I will do this in a second PR because of the complexity of the code here, that way if any bugs are introduced they belong to a different commit.
|
|
||
| def load_yaml(stream): | ||
| #!!! Yaml should only be loaded using this function. Otherwise the dict ordering may be broken in Python versions prior to 3.6 | ||
| #See https://stackoverflow.com/questions/5121931/in-python-how-can-you-load-yaml-mappings-as-ordereddicts/21912744#21912744 |
There was a problem hiding this comment.
nit: Should we also drop this if it's no longer applicable for Python 3.7?
There was a problem hiding this comment.
Yes, great catch. We can drop this whole file, actually.
Done.
connor-mccarthy
force-pushed
the
make-v2-hermetic
branch
from
4b993df to
57728b8
Compare
|
/lgtm Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
* move v1 files to v2 * format with yapf * remove unused imports * clean up * update copyright * move imports to module top level * apply some pylint changes * loosen pylintrc * remove v2_yaml_utils.py
Description of your changes:
The primary work completed by this PR is:
Other changes include:
Reviewer notes:
I recommend stepping through changes commit-by-commit for readability.
Checklist: