Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): move tests to deprecated_tests #7402

Conversation

connor-mccarthy
Copy link
Member

Description of your changes:
Moves sdk/python/tests/ to sdk/python/deprecated_tests. This achieves two things:

  1. Aligns the name of the tests with what they are testing, per out convention.
  2. Locates the tests in a more intuitive location in our directory heirarchy, consistent with where other tests live.

Costs: Includes the deprecated_tests/ dir in the kfp package (820KB).

Checklist:



@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from connor-mccarthy after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy
Copy link
Member Author

/test all

@google-oss-prow
Copy link

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 6ad595c link true /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@connor-mccarthy connor-mccarthy marked this pull request as ready for review March 10, 2022 23:42
@ji-yaqi
Copy link
Contributor

ji-yaqi commented Mar 10, 2022

Hi @connor-mccarthy, I feel we should be careful making directory changes as people might rely on our link as examples.

V1 is moving to deprecated folder to ensure coverage on sample tests (context: #7238). We will ultimately remove deprecated namespace and make it only in sdk/release-1.8 branch.

We might think of removing the tests folder ultimately, which might be better with a design doc of improving test infra overall and let users know for some time before removing them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants