feat(sdk)!: move v1 to deprecated folder #7291
Conversation
|
Skipping CI for Draft Pull Request. |
| @@ -245,5 +245,5 @@ | |||
| } | |||
| }, | |||
| "schemaVersion": "2.1.0", | |||
| "sdkVersion": "kfp-1.8.9" | |||
| "sdkVersion": "kfp-1.8.11" | |||
There was a problem hiding this comment.
nit: you don't need to update the v2 golden files, they are unrelated to this change. Leaving them alone can give you a smaller diff.
|
New changes are detected. LGTM label has been removed. |
|
/retest |
|
/test kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipelines-samples-v2 |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/test kubeflow-pipeline-e2e-test |
| import os | ||
|
|
||
| import kfp | ||
| import kfp.onprem |
There was a problem hiding this comment.
We should make this sample work, as it's one of the pre-load sample pipelines shipped with KFP release. Removing this sample is actually the cause for the backend e2e test failure.
What was the issue if we use kfp.deprecated here?
|
@ji-yaqi: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I'm preparing a PR to the |
* chore(sdk): move v1 to deprecated * fix testsg * fix testsg * fix setup.py * fix test * s' * fix tests * fix test * retore v2 test changes * fix py3.6 test * fix py3.6 test * fix py3.6 import fallback error * remove deprecated * fix samples test * sample test * fix samples * add readme * restroe test * python require * remove path * fix tests * inteegration tests * remove tfx tests for dependency with kfp v1 * fix e2e * fix e2e * fix integration tests * fix sampe * move client down * change to kfp * add import alias * fix * runid * fix dsl * only use kfp for function * revert train_until_good * tfx test * kfp * try import * onprem
No description provided.