Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): Relax Typing Extensions Constraint #7288

Merged
merged 3 commits into from
Feb 15, 2022

Conversation

hmc-cs-mdrissi
Copy link
Contributor

Description of your changes:
Typing extensions changed version scheme a couple months ago. The old schema was not semantic versioning based and was python version based. The new scheme is based on semantic versioning and moved to 4.0. 4.0+ is fully backwards compatible. So it's safe to move the bound to 5.0. And current bound unnecessarily prevents usage of some optional typing features like typeguard and pretty soon variadic types.

I would also be open to dropping upper bound entirely. It's unlikely most breaking type changes would affect normal type usage. It would heavily fracture python typing ecosystem for something core to change. And current stability focus of python devs (includes typing portion) I think it should be safe for most packages to not upper bound typing extensions. If in the future a package discovers they are affected they can add upper bound then.

Checklist:

@google-oss-prow
Copy link

Hi @hmc-cs-mdrissi. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Feb 9, 2022
@hmc-cs-mdrissi
Copy link
Contributor Author

Not sure how to redo the CLA check, but I've just now signed the CLA.

@chensun
Copy link
Member

chensun commented Feb 15, 2022

/ok-to-test

@chensun
Copy link
Member

chensun commented Feb 15, 2022

/lgtm
/approve

Thanks!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 9be1720 into kubeflow:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants