Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk.v2): Fix importer not using correct output artifact type #7235

Merged
merged 2 commits into from
Jan 31, 2022
Merged

fix(sdk.v2): Fix importer not using correct output artifact type #7235

merged 2 commits into from
Jan 31, 2022

Conversation

chensun
Copy link
Member

@chensun chensun commented Jan 31, 2022

Description of your changes:

Checklist:

@chensun chensun requested a review from ji-yaqi January 31, 2022 17:11
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from chensun after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested a review from zijianjoy January 31, 2022 17:12
@google-oss-prow
Copy link

@chensun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 ed242fa link true /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zijianjoy
Copy link
Collaborator

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 31, 2022
@ji-yaqi
Copy link
Contributor

ji-yaqi commented Jan 31, 2022

/lgtm
Thanks @chensun!

@chensun
Copy link
Member Author

chensun commented Jan 31, 2022

@chensun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 ed242fa link true /test kubeflow-pipelines-samples-v2

This was due to some infra failure which is being addressed separately.
This PR shouldn't affect any of the samples tests.

@chensun chensun merged commit 1acb90f into kubeflow:master Jan 31, 2022
@chensun chensun deleted the fix-importer-output-type branch January 31, 2022 22:34
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
@chensun @abaland
fix(sdk.v2): Fix importer not using correct output artifact type (kub…
4f20625 
…eflow#7235)

* fix importer output type

* release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ji-yaqi ji-yaqi Awaiting requested review from ji-yaqi

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@ji-yaqi ji-yaqi

@zijianjoy zijianjoy

Labels
lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chensun @zijianjoy @ji-yaqi