Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk.v1): add importer_spec metadata to v1 #7180

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

ji-yaqi
Copy link
Contributor

@ji-yaqi ji-yaqi commented Jan 20, 2022

No description provided.

@google-oss-prow
Copy link

@ji-yaqi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 4ecd82b link true /test kubeflow-pipelines-samples-v2
kubeflow-pipelines-tfx-python37 4ecd82b link true /test kubeflow-pipelines-tfx-python37

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chensun
Copy link
Member

chensun commented Jan 20, 2022

@ji-yaqi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 4ecd82b link true /test kubeflow-pipelines-samples-v2
kubeflow-pipelines-tfx-python37 4ecd82b link true /test kubeflow-pipelines-tfx-python37

For the tfx test failure, cherry-pick #7143 would fix it--so that we don't fail the test every time we back port changes.
For the v2 sample tests, you can ignore it. I'll remove the folder and update test config soon.

@chensun
Copy link
Member

chensun commented Jan 20, 2022

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Jan 20, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ji-yaqi ji-yaqi merged commit d3d3c9f into kubeflow:sdk/release-1.8 Jan 21, 2022
@ji-yaqi ji-yaqi deleted the sdk/release-1.8 branch January 21, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants