Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add metadata field for importer #7112

Merged
merged 4 commits into from
Jan 6, 2022

Conversation

ji-yaqi
Copy link
Contributor

@ji-yaqi ji-yaqi commented Dec 23, 2021

No description provided.

@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Dec 23, 2021
sdk/RELEASE.md Outdated Show resolved Hide resolved
sdk/python/kfp/v2/compiler/pipeline_spec_builder.py Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Jan 5, 2022

LGTM +1.

@chensun
Copy link
Member

chensun commented Jan 5, 2022

@ji-yaqi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-tfx-python37 fa2f2c7 link true /test kubeflow-pipelines-tfx-python37

#7143 will fix the failing test.

@chensun
Copy link
Member

chensun commented Jan 5, 2022

/lgtm
/approve

Thanks!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ji-yaqi
Copy link
Contributor Author

ji-yaqi commented Jan 5, 2022

/test kubeflow-pipelines-tfx-python37

1 similar comment
@chensun
Copy link
Member

chensun commented Jan 6, 2022

/test kubeflow-pipelines-tfx-python37

@google-oss-prow google-oss-prow bot merged commit 5a29d7f into kubeflow:master Jan 6, 2022
zijianjoy pushed a commit to zijianjoy/pipelines that referenced this pull request Jan 11, 2022
* feat(sdk): add metadata

* metadata

* release notes

* address comments
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
* feat(sdk): add metadata

* metadata

* release notes

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants