Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): fix bug in checking values in _param_values. Fixes #6799 #6965

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

michaelliqx
Copy link
Contributor

@michaelliqx michaelliqx commented Nov 26, 2021

Description of your changes:
change the checking data type from object to dict and list
Fix #6799

Checklist:

@google-oss-prow
Copy link

Hi @michaelliqx. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelliqx
Copy link
Contributor Author

/assign @chensun

@lynnmatrix
Copy link
Member

/ok-to-test

@michaelliqx michaelliqx changed the title fix(sdk): fix bug in checking values in _param_values. Fixes: #6799 fix(sdk): fix bug in checking values in _param_values. Fixes #6799 Nov 26, 2021
@chensun
Copy link
Member

chensun commented Nov 30, 2021

/lgtm

@michaelliqx, once this is merged, can you help cherrypick the change into sdk/release-1.8 branch? Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Nov 30, 2021
@chensun
Copy link
Member

chensun commented Dec 1, 2021

/lgtm

@michaelliqx, once this is merged, can you help cherrypick the change into sdk/release-1.8 branch? Thanks!

Also, can you add an entry in the release note for this change? Thanks!
https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md#bug-fixes-and-other-changes

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a71fce0 into kubeflow:master Dec 3, 2021
chensun pushed a commit to chensun/pipelines that referenced this pull request Dec 3, 2021
google-oss-prow bot pushed a commit that referenced this pull request Dec 3, 2021
@chensun chensun added cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` labels Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` cla: yes lgtm ok-to-test size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk] superfluous isinstance check in local run
3 participants