Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk.v2): Fix regression on optional inputs #6905

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Nov 13, 2021

Description of your changes:

Checklist:

@chensun chensun requested a review from ji-yaqi November 13, 2021 07:32
@google-cla google-cla bot added the cla: yes label Nov 13, 2021
@google-oss-prow google-oss-prow bot requested a review from Ark-kun November 13, 2021 07:32
@chensun chensun removed the request for review from Ark-kun November 13, 2021 08:37
@chensun
Copy link
Member Author

chensun commented Nov 13, 2021

/retest

@ji-yaqi
Copy link
Contributor

ji-yaqi commented Nov 15, 2021

/lgtm
/approve
Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Nov 15, 2021
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ji-yaqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 9ee4534 into kubeflow:master Nov 15, 2021
@chensun chensun deleted the fix-optional-inputs branch November 15, 2021 21:01
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
* Fix regression on optional inputs

* add release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants