Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): Remove sdk/python/kfp/v2/google directory for v2 #6886

Merged
merged 7 commits into from
Nov 10, 2021
Merged

chore(sdk): Remove sdk/python/kfp/v2/google directory for v2 #6886

merged 7 commits into from
Nov 10, 2021

Conversation

ji-yaqi
Copy link
Contributor

@ji-yaqi ji-yaqi commented Nov 9, 2021

Per deprecation warning #6851

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-cla google-cla bot added the cla: yes label Nov 9, 2021
@ji-yaqi ji-yaqi changed the title Delete sdk/python/kfp/v2/google directory chore(sdk): Remove sdk/python/kfp/v2/google directory for v2 Nov 9, 2021
@google-oss-prow google-oss-prow bot requested review from Bobgy and chensun November 9, 2021 19:56
@ji-yaqi ji-yaqi marked this pull request as ready for review November 9, 2021 19:57
chensun
chensun approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Nov 10, 2021
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit b7fd47f into kubeflow:master Nov 10, 2021
@haoxins
Copy link
Contributor

haoxins commented Nov 11, 2021

Hi, @chensun Can we cherry pick these changes into branch sdk/release-1.8 and release a new version?
Thanks very much 🙇

@ji-yaqi
Copy link
Contributor Author

ji-yaqi commented Nov 11, 2021

Hi @haoxins, merging this into sdk/release-1.8 will break the existing users using KFP AiPlatformClient. We will release a 2.0 with breaking changes in.

May I know why you want this merged in?

@chensun chensun mentioned this pull request Nov 23, 2021
Merged
1 task
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
@ji-yaqi @abaland
chore(sdk): Remove sdk/python/kfp/v2/google directory for v2 (kubeflo…
f66f57b 
…w#6886)

* Delete sdk/python/kfp/v2/google directory

* Update RELEASE.md

* Update MANIFEST.in

* Update requirements-test.txt

* Update requirements.in

* fix setup

* remove test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun approved these changes

@Bobgy Bobgy Awaiting requested review from Bobgy

Assignees

@chensun chensun

Labels
approved cla: yes lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ji-yaqi @haoxins @chensun @google-oss-robot