Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk.v2): Fix importer ignoring reimport setting, and switch to Protobuf.Value for import uri. #6827

Merged
merged 4 commits into from
Oct 29, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Oct 28, 2021

Description of your changes:

Checklist:

@chensun
Copy link
Member Author

chensun commented Oct 29, 2021

/retest

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun chensun added the lgtm label Oct 29, 2021
@google-oss-robot google-oss-robot merged commit 8c6843f into kubeflow:master Oct 29, 2021
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
…Protobuf.Value for import uri. (kubeflow#6827)

* fix importer

* release note

* remove error usage in test sample

* disable importer test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants