feat(sdk): add load_component_from_* #6822
Conversation
| """Loads component from file. | ||
|
|
||
| Args: | ||
| file_path: A string containing path to the file. The file could be YAML file or a zip file with a 'component.yaml' file inside. |
There was a problem hiding this comment.
The file could be YAML file or a zip file with a 'component.yaml' file inside.
Sorry, I may have mislead you. I think we should add the zip support so it's fully backward compatible.
(Earlier I was talking about v1 compiler can produce zip files, because KFP UI support uploading zip, and we don't need to do it for v2)
pipelines/sdk/python/kfp/compiler/compiler.py
Lines 1130 to 1145 in 40d8242
There was a problem hiding this comment.
Synced offline, will add this feature if requested.
| with open(file_path, 'rb') as component_stream: | ||
| return load_component_from_text(component_stream) | ||
|
|
||
| def load_component_from_url(url: str, auth=None) -> base_component.BaseComponent: |
There was a problem hiding this comment.
nit: Add docstring for public method, also type annotate auth (do we expect a string or what? I was not familiar with this usage).
There was a problem hiding this comment.
Added doc strings. auth should be Any type here, depending on the URL request.
| - {outputPath: output1} | ||
| """) | ||
|
|
||
| class YamlComponentTest(parameterized.TestCase): |
There was a problem hiding this comment.
nit: seems like you are not using parameterized, so maybe change this to unittest?
| def test_load_component_from_text(self): | ||
| component = yaml_component.load_component_from_text(SAMPLE_YAML) | ||
| self.assertEqual(component.component_spec.name, 'component_1') | ||
| self.assertEqual(component._component_inputs, {'input1'}) |
There was a problem hiding this comment.
nit: maybe check outputs and container as well?
|
/test kubeflow-pipelines-samples-v2 |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* feat(sdk): add load_component_from_* * address comments' : * update release notes
No description provided.