Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): Add missing retry policy. #6808

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Oct 26, 2021

Description of your changes:

Add missing retry policy to allowed list. Note: we could also drop this list entirely and allow validation to happen server-side instead. Any preference?

Checklist:

@google-oss-robot
Copy link

Hi @jmcarp. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmcarp jmcarp changed the title (fix): Add missing retry policy. fix(sdk): Add missing retry policy. Oct 26, 2021
@jmcarp jmcarp force-pushed the jmcarp/fix-retry-policies branch from 3870400 to b03d656 Compare October 26, 2021 23:21
@chensun
Copy link
Member

chensun commented Oct 27, 2021

@jmcarp can you please add a release note entry for this? Thanks!

/lgtm

@jmcarp jmcarp force-pushed the jmcarp/fix-retry-policies branch from a98586f to 6ec145e Compare October 28, 2021 00:03
@google-oss-robot
Copy link

@jmcarp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 6ec145e link true /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member

chensun commented Oct 28, 2021

sample tests failure was irrelevant (#6815), and I don't think this PR may affect any of the sample test we have.
Going to ignore the test failures.

kfp_server_api.exceptions.ApiException: (500)
Reason: Internal Server Error
HTTP response headers: HTTPHeaderDict({'Content-Type': 'application/json', 'Date': 'Thu, 28 Oct 2021 00:05:38 GMT', 'Vary': 'Origin', 'X-Content-Type-Options': 'nosniff', 'X-Frame-Options': 'SAMEORIGIN', 'X-Powered-By': 'Express', 'X-Xss-Protection': '0', 'Transfer-Encoding': 'chunked', 'Set-Cookie': 'S=cloud_datalab_tunnel=HMzjedbUtOfvCUxatmKXGynHsJuhMxw5of6HG3PVShE; Path=/; Max-Age=3600'})
HTTP response body: {"error":"Failed to create a new run.: InternalServerError: Failed to store run v2-sample-test-wt7vr to table: Error 1205: Lock wait timeout exceeded; try restarting transaction","code":13,"message":"Failed to create a new run.: InternalServerError: Failed to store run v2-sample-test-wt7vr to table: Error 1205: Lock wait timeout exceeded; try restarting transaction","details":[{"@type":"type.googleapis.com/api.Error","error_message":"Internal Server Error","error_details":"Failed to create a new run.: InternalServerError: Failed to store run v2-sample-test-wt7vr to table: Error 1205: Lock wait timeout exceeded; try restarting transaction"}]}

@chensun chensun merged commit ec4ab2d into kubeflow:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants