chore(sdk.v2): Implement LoopArgument and LoopArgumentVariable v2 #6755
Conversation
| """Extracts the loop item type. | ||
|
|
||
| This method is used for extract the item type from a collection type. | ||
| For example:: |
There was a problem hiding this comment.
nit: extra : here (same for below)
There was a problem hiding this comment.
We aren't very consistent on this usage. But :: is used for code block: https://devguide.python.org/documenting/#source-code
That said, the content below isn't strictly code, so removed the extra :.
There was a problem hiding this comment.
Ah I see, thanks for explaining!
| if name_override is None: | ||
| super().__init__(name=self._make_name(name_code), **kwargs) | ||
| else: | ||
| super().__init__(name=name_override, **kwargs) |
There was a problem hiding this comment.
Does this mean name_override takes priority over name_code? or do we expect only one of name_code and name_override to appear?
There was a problem hiding this comment.
That's a good point. Yes, we expect only one of them to appear. Added a check.
|
@chensun: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ji-yaqi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is new code not used anywhere, it can't affect kubeflow-pipelines-samples-v2 test. |
Description of your changes:
Checklist: