Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): Fix type_utils #6719

Merged
merged 3 commits into from
Oct 12, 2021
Merged

fix(sdk): Fix type_utils #6719

merged 3 commits into from
Oct 12, 2021

Conversation

chongyouquan
Copy link
Contributor

@chongyouquan chongyouquan commented Oct 12, 2021

Description of your changes:

Checklist:

@chensun
Copy link
Member

chensun commented Oct 12, 2021

Thanks @chongyouquan for the fix.
Maybe add an entry in the release note? https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md

@chensun
Copy link
Member

chensun commented Oct 12, 2021

/lgtm
/approve

Thanks!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chongyouquan chongyouquan merged commit 14b3d67 into master Oct 12, 2021
@chongyouquan chongyouquan deleted the chongyouquan-patch-1 branch October 12, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants