Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk.v2): Implement PipelineTask creation #6713

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Oct 11, 2021

Description of your changes:

  • Implement PipelineTask.__init__() with some logics from _component_bridge.py.
  • Rename filesdk/python/kfp/v2/components/experimental/component_spec.py to sdk/python/kfp/v2/components/experimental/structures.py.
  • Rename IfPresentPlaceholder.if_present to IfPresentPlaceholder.if_structure.
  • Rename ConcatPlaceholder.concat to ConcatPlaceholder.items.

Checklist:

@chensun
Copy link
Member Author

chensun commented Oct 11, 2021

/test kubeflow-pipelines-samples-v2

@ji-yaqi
Copy link
Contributor

ji-yaqi commented Oct 11, 2021

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ji-yaqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit d311463 into kubeflow:master Oct 11, 2021
@chensun chensun deleted the pipeline-task branch October 11, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants