Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sample): upgrade katib and kfp sdk versions in e2e mnist tutorial #6712

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

zijianjoy
Copy link
Collaborator

@zijianjoy zijianjoy commented Oct 10, 2021

Description of your changes:

To prepare for kubeflow 1.4 release

Checklist:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla google-cla bot added the cla: yes label Oct 10, 2021
@zijianjoy zijianjoy changed the title tutorial: upgrade katib and kfp sdk versions in e2e mnist tutorial fix(components): upgrade katib and kfp sdk versions in e2e mnist tutorial Oct 10, 2021
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update @zijianjoy!
/lgtm

@zijianjoy
Copy link
Collaborator Author

/retest-required

@chensun chensun changed the title fix(components): upgrade katib and kfp sdk versions in e2e mnist tutorial fix(sample): upgrade katib and kfp sdk versions in e2e mnist tutorial Oct 11, 2021
@chensun
Copy link
Member

chensun commented Oct 11, 2021

Just curious, what was breaking before the sdk upgrade?

@zijianjoy
Copy link
Collaborator Author

zijianjoy commented Oct 11, 2021

@chensun There was a new version of katib coming out, and I am preparing the Kubeflow 1.4 release, which carries KFP 1.7 backend along. Therefore I am upgrading katib and KFP to encourage users to adopt the latest change of both SDKs.

@chensun
Copy link
Member

chensun commented Oct 11, 2021

@chensun There was a new version of katib coming out, and I am preparing the Kubeflow 1.4 release, which carries KFP 1.7 backend along. Therefore I am upgrading katib and KFP to encourage users to adopt the latest change of both SDKs.

I see. The title made me think there was something to be fixed, and it's not clear to me what we have changed in the SDK could potentially affect this sample.
I would probably use chore(sample) instead.

/lgtm

@zijianjoy zijianjoy changed the title fix(sample): upgrade katib and kfp sdk versions in e2e mnist tutorial chore(sample): upgrade katib and kfp sdk versions in e2e mnist tutorial Oct 11, 2021
@zijianjoy
Copy link
Collaborator Author

@chensun You are right, it is my bad to use fix here. Updated to chore, thank you Chen!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 991473d into kubeflow:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants