-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sample): upgrade katib and kfp sdk versions in e2e mnist tutorial #6712
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update @zijianjoy!
/lgtm
/retest-required |
Just curious, what was breaking before the sdk upgrade? |
@chensun There was a new version of katib coming out, and I am preparing the Kubeflow 1.4 release, which carries KFP 1.7 backend along. Therefore I am upgrading katib and KFP to encourage users to adopt the latest change of both SDKs. |
I see. The title made me think there was something to be fixed, and it's not clear to me what we have changed in the SDK could potentially affect this sample. /lgtm |
@chensun You are right, it is my bad to use |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
To prepare for kubeflow 1.4 release
Checklist: