Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk.v2): fix function-based components not preserving the namespace of GCPC artifact types. #6702

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Oct 7, 2021

Description of your changes:
Fixing the following error when passing GCPC-typed output from a yaml component to a function-based component.

InconsistentTypeException: Incompatible argument passed to the input "model" of component "Classification model eval metrics": Argument type "google.VertexModel" is incompatible with the input type "VertexModel"

Checklist:

@ji-yaqi
Copy link
Contributor

ji-yaqi commented Oct 7, 2021

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ji-yaqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member Author

chensun commented Oct 7, 2021

/test kubeflow-pipelines-samples-v2

@google-oss-robot
Copy link

@chensun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 b4f41e9 link true /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chensun
Copy link
Member Author

chensun commented Oct 7, 2021

kubeflow-pipelines-samples-v2 is flaky, and shouldn't be affected by this PR.

@chensun chensun merged commit 2b2e5fd into kubeflow:master Oct 7, 2021
@chensun chensun deleted the gcpc-types branch October 7, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants