feat(frontend): Runtime DAG in RunDetailsV2. Fix #6673 #6694
Conversation
|
/test kubeflow-pipelines-samples-v2 |
|
/retest-required |
|
Merging this for now to enable upcoming tasks. Feel free to add comments and I will accommodate them in new PR. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| data.run.pipeline_spec.workflow_manifest | ||
| ) { | ||
| // TODO(zijianjoy): We need to switch to use pipeline_manifest for new API implementation. | ||
| const isIR = isIrPipeline(data.run.pipeline_spec.workflow_manifest); |
There was a problem hiding this comment.
nit: avoid the word IR in code
There was a problem hiding this comment.
It makes sense, updated.
| const { isSuccess, data } = useQuery<ApiRunDetail, Error>( | ||
| ['run_detail', { id: runId }], | ||
| () => Apis.runServiceApi.getRun(runId), | ||
| { staleTime: 30000 }, |
There was a problem hiding this comment.
nit: it would be easier for me to understand if you make this a constant or comment about what the unit is.
There was a problem hiding this comment.
That is a good point, extracting to constant.
Description of your changes:
Fix #6673
Partial #6686
Partial #6400
poc-runtimedag.mov
Checklist: