Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk.v2): Fix a couple of ParallelFor related bugs. Fixes #6383, fixes #6628 #6643

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Sep 29, 2021

Description of your changes:
Fixes #6383
Fixes #6628

  • Fix get get inputs logic for loop arguments.
  • Fix "punch the hole" logics for ParallelFor and Condition.
  • Clean up some unused code.
  • Add test cases reported by the above issues and more.
  • Combine test samples: pipeline_with_loop_output.py, pipeline_with_loop_parameter.py, and pipeline_with_loop_static.py into pipeline_with_loops.py

Checklist:

@ji-yaqi
Copy link
Contributor

ji-yaqi commented Sep 29, 2021

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ji-yaqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit b466f59 into kubeflow:master Sep 29, 2021
@chensun chensun deleted the fix-loop-bug branch October 5, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants