Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Local runner supports additional docker options. Fixes #6598 #6599

Merged
merged 4 commits into from
Sep 24, 2021

Conversation

lynnmatrix
Copy link
Member

Description of your changes:
Fix #6598

Pass additional docker options to local runner through ExecutionMode, e.g.:

run_pipeline_func_locally(
    _pipeline,
    {},
    execution_mode=LocalClient.ExecutionMode(mode="docker",
                                            docker_options=["-e", "foo=bar"])
)

Checklist:

@google-cla google-cla bot added the cla: yes label Sep 23, 2021
@ji-yaqi ji-yaqi requested review from chensun and removed request for Ark-kun September 23, 2021 18:22
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lynnmatrix Thanks for the PR. Can you please add an entry in the release note under "Current version > bug fixes and other changes"?
https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md

sdk/python/kfp/_local_client.py Outdated Show resolved Hide resolved
sdk/python/kfp/_local_client.py Outdated Show resolved Hide resolved
@lynnmatrix lynnmatrix requested a review from chensun September 24, 2021 14:25
@chensun
Copy link
Member

chensun commented Sep 24, 2021

/lgtm
/approve

Thanks!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 36e627d into kubeflow:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Pass additional options to docker on local runner
3 participants