Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Enable re-use of PVC with VolumeOp #6582

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

midhun1998
Copy link
Member

@midhun1998 midhun1998 commented Sep 18, 2021

Description of your changes:
Ideally, VolumeOp should create a unique PVC for each run. But in the case where the same PVC has to be re-used for recurring runs generate_name argument can be set to False.

Fixes: #6562

Checklist:

@google-oss-robot
Copy link

Hi @midhun1998. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdk/python/kfp/dsl/_volume_op.py Outdated Show resolved Hide resolved
sdk/python/kfp/dsl/_volume_op.py Outdated Show resolved Hide resolved
@chensun
Copy link
Member

chensun commented Sep 22, 2021

/ok-to-test

@chensun
Copy link
Member

chensun commented Sep 22, 2021

@midhun1998 Can you please add an entry in the release note:
https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md

Thanks!

@midhun1998 midhun1998 force-pushed the feature/volumeop-resue branch from 01761ec to dc7d327 Compare September 23, 2021 04:31
@midhun1998
Copy link
Member Author

Squashed commits and added change log to RELEASE.md. @chensun .

@chensun
Copy link
Member

chensun commented Sep 23, 2021

Squashed commits and added change log to RELEASE.md. @chensun .

Thanks!
JFYI, on this repo, you don't have to squash commits. When the PR is merged, all commits will be squashed automatically.

@chensun
Copy link
Member

chensun commented Sep 23, 2021

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member

chensun commented Sep 23, 2021

/retest

@google-oss-robot google-oss-robot merged commit 24331a9 into kubeflow:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Add option to allow VolumeOp to re-use PVC
3 participants