-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): Enable re-use of PVC with VolumeOp #6582
feat(sdk): Enable re-use of PVC with VolumeOp #6582
Conversation
Hi @midhun1998. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@midhun1998 Can you please add an entry in the release note: Thanks! |
01761ec
to
dc7d327
Compare
Squashed commits and added change log to |
Thanks! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Description of your changes:
Ideally,
VolumeOp
should create a unique PVC for each run. But in the case where the same PVC has to be re-used for recurring runsgenerate_name
argument can be set toFalse
.Fixes: #6562
Checklist: