Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk.v2): use Annotated rather than Union hack #6573

Merged
merged 4 commits into from
Sep 16, 2021

Conversation

judahrand
Copy link
Contributor

@judahrand judahrand commented Sep 15, 2021

Description of your changes:
This PR deals with the TODO comment by adding typing_extensions as a dependency (it was already required via pydantic) and either importing from standard lib or typing_extensions.

Checklist:

@google-oss-robot
Copy link

Hi @judahrand. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Please add an entry in release note.

@@ -34,3 +34,4 @@ fire>=0.3.1,<1
google-api-python-client>=1.7.8,<2
dataclasses>=0.8,<1; python_version<"3.7"
pydantic>=1.8.2,<2
typing-extensions>=3.10.0.2,<4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add this in setup.py as well, we can't rely on an indirect dependency from pydantic.
Also this better be conditioned by a Python version, 3.9 I think?
See dataclass for example:

# Standard library backports
'dataclasses;python_version<"3.7"',

@chensun chensun changed the title feat(sdk.v2): use Annotated rather than Union hack chore(sdk.v2): use Annotated rather than Union hack Sep 15, 2021
@chensun
Copy link
Member

chensun commented Sep 15, 2021

/ok-to-test

@chensun
Copy link
Member

chensun commented Sep 16, 2021

/lgtm
/approve

Thanks!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit c605c51 into kubeflow:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants