Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update kustomize/manifests OWNERS #6561

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Sep 14, 2021

Description of your changes:

Checklist:

@google-cla google-cla bot added the cla: yes label Sep 14, 2021
@Bobgy Bobgy changed the title Update kustomize/manifests OWNERS chore: Update kustomize/manifests OWNERS Sep 14, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 14, 2021

Hi @zijianjoy,
/Approve

@zijianjoy
Copy link
Collaborator

Thank you Yuan! Would you like to still sit on the approver list? It is best practice to avoid one-point failure by having more than one approver.

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 15, 2021

@zijianjoy no worries, owners have inheritance, I am still an owner for this folder, because I am a root owner

@zijianjoy
Copy link
Collaborator

/lgtm
/approve

Thank you Yuan for confirming! LGTMed.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 55a2fb5 into master Sep 15, 2021
@google-oss-robot google-oss-robot deleted the Bobgy-patch-6 branch September 15, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants