Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk.v2): Fix passing in "" to a str parameter causes the parameter to receive it as None instead #6533

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Sep 8, 2021

Description of your changes:

Checklist:

@neuromage
Copy link
Contributor

/lgtm

@chensun
Copy link
Member Author

chensun commented Sep 8, 2021

/test kubeflow-pipelines-samples-v2

1 similar comment
@chensun
Copy link
Member Author

chensun commented Sep 8, 2021

/test kubeflow-pipelines-samples-v2

@chensun
Copy link
Member Author

chensun commented Sep 9, 2021

/retest

@chensun
Copy link
Member Author

chensun commented Sep 9, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 38e826b into kubeflow:master Sep 9, 2021
@chensun chensun deleted the empty-string branch September 9, 2021 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants